Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility - Teacher - Submission Filter Picker - Dynamic font size #3056

Merged

Conversation

ndrsszsz
Copy link
Contributor

@ndrsszsz ndrsszsz commented Jan 13, 2025

affects: Teacher
release note: None
test plan: All submission filter options should be displayed correctly even when the font size is set to the maximum.

Screenshots

BeforeAfter

Checklist

  • Follow-up e2e test ticket created
  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

affects: Teacher
release note: None
test plan: All submission filter options should be displayed correctly even when the font size is set to the maximum.
@inst-danger
Copy link
Contributor

Teacher Build QR Code:

@inst-danger
Copy link
Contributor

inst-danger commented Jan 13, 2025

Warnings
⚠️ This pull request will not generate a release note.
⚠️ One or more files are below the minimum test coverage 50%

Affected Apps: Teacher

MBL-18298

Coverage New % Master % Delta
Canvas iOS 91.28% 91.29% -0.01%
Core/Core/Common/CommonModels/Store/FetchedCollection.swift 48.72% 48.72% 0%
Core/Core/Common/Extensions/Foundation/CGSizeExtensions.swift 0% 0% 0%
Core/Core/Features/Courses/SmartSearch/Model/CourseSmartSearchViewAttributes.swift 30.77% 30.77% 0%
Core/Core/Common/Extensions/SwiftUI/UIColor+Color.swift 0% 0% 0%
Core/Core/Features/Search/Model/SearchSupportButtonModel.swift 0% 0% 0%
Core/Core/Common/CommonModels/AppEnvironment/AppEnvironmentOverride.swift 32.76% 32.76% 0%

Generated by 🚫 dangerJS against 7612799

Copy link
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1
Tested on iOS 18.2.1, Teacher app.

My only note is about rows of:
"Scored below..."
"Scored above..."

They are somehow confusing, perhaps adding a space before dots would make it better. Or, something like:
"Scored below [...]"

@ndrsszsz
Copy link
Contributor Author

QA +1 Tested on iOS 18.2.1, Teacher app.

My only note is about rows of: "Scored below..." "Scored above..."

They are somehow confusing, perhaps adding a space before dots would make it better. Or, something like: "Scored below [...]"

@suhaibabsi-inst I agree. I will discuss this with Marci.

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@rh12 rh12 merged commit 37f6baf into master Jan 24, 2025
4 checks passed
@rh12 rh12 deleted the bugfix/MBL-18298-a11y-teacher-submission-filter-picker-font-size branch January 24, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants